Repository navigation
fix(changelog): skip non-compliant commit subjects when building changelog - #536
Merged
Merged
Conversation
…gelog This should fix duplicate entries in the changelog Closes #510
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
=======================================
Coverage 98.00% 98.00%
=======================================
Files 39 39
Lines 1551 1552 +1
=======================================
+ Hits 1520 1521 +1
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix duplicate entries in the changelog
Closes #510
Description
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Only entries that have a subject compliant with conventional commits should be included.
Steps to Test This Pull Request
Run on our own commitizen:
Before it was including duplicated entries, now only good ones.
Additional context